From 0c050ab33eb862454610622e70b0fcab9e31cf18 Mon Sep 17 00:00:00 2001 From: Arthur Tazhitdinov Date: Sun, 1 Feb 2026 22:17:07 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/ci.yml | 5 +---- .github/workflows/pr-writer.yml | 9 +++++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7195867a..6ba1e834 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,12 +69,9 @@ jobs: set -euo pipefail pio run | tee pio.log - - name: Capture short SHA - id: short_sha - run: echo "short=${GITHUB_SHA::7}" >> "$GITHUB_OUTPUT" - name: Extract firmware stats - id: fw_stats + run: | set -euo pipefail ram_line="$(grep -E "RAM:\\s" -m1 pio.log || true)" diff --git a/.github/workflows/pr-writer.yml b/.github/workflows/pr-writer.yml index 0c5d8a56..a60565f0 100644 --- a/.github/workflows/pr-writer.yml +++ b/.github/workflows/pr-writer.yml @@ -1,4 +1,4 @@ -name: PR writes (label + comment) +name: PR writer (label + comment) on: pull_request_target: @@ -16,6 +16,8 @@ jobs: # Safe: labeler reads files from the base repo by default in pull_request_target context. # Do NOT checkout PR head. - uses: actions/labeler@v5 + with: + configuration-path: .github/labeler.yml comment_firmware: runs-on: ubuntu-latest @@ -63,7 +65,10 @@ jobs: const fw = artifacts.find(a => a.name === "firmware-bin"); const meta = artifacts.find(a => a.name === "build-meta"); - if (!meta) core.setFailed("build-meta artifact not found in CI run artifacts."); + if (!meta) { + core.setFailed("build-meta artifact not found in CI run artifacts."); + return; + } // firmware-bin is nice-to-have for linking; fail if you want. core.setOutput("fw_id", fw ? String(fw.id) : ""); core.setOutput("meta_id", String(meta.id));