From 1867b55f5296f8c365527f678a0444dce242adef Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Thu, 22 Jan 2026 11:25:20 +0100 Subject: [PATCH] apply suggestion --- src/CrossPointSettings.h | 5 ++++- src/main.cpp | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/CrossPointSettings.h b/src/CrossPointSettings.h index 8ce32a2c..1a5221a3 100644 --- a/src/CrossPointSettings.h +++ b/src/CrossPointSettings.h @@ -54,6 +54,8 @@ class CrossPointSettings { // Short power button press actions enum SHORT_PWRBTN { IGNORE = 0, SLEEP = 1, PAGE_TURN = 2 }; + static constexpr uint16_t SHORT_PRESS_DURATION_MS = 10; + static constexpr uint16_t LONG_PRESS_DURATION_MS = 400; // Hide battery percentage enum HIDE_BATTERY_PERCENTAGE { HIDE_NEVER = 0, HIDE_READER = 1, HIDE_ALWAYS = 2 }; @@ -101,7 +103,8 @@ class CrossPointSettings { static CrossPointSettings& getInstance() { return instance; } uint16_t getPowerButtonDuration() const { - return (shortPwrBtn == CrossPointSettings::SHORT_PWRBTN::SLEEP) ? 10 : 400; + return (shortPwrBtn == CrossPointSettings::SHORT_PWRBTN::SLEEP) + ? SHORT_PRESS_DURATION_MS : LONG_PRESS_DURATION_MS; } int getReaderFontId() const; diff --git a/src/main.cpp b/src/main.cpp index 12e4fbfb..b6370fac 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -154,7 +154,7 @@ void enterNewActivity(Activity* activity) { // Verify power button press duration on wake-up from deep sleep // Pre-condition: isWakeupByPowerButton() == true void verifyPowerButtonDuration() { - if (SETTINGS.getPowerButtonDuration() <= 10) { + if (SETTINGS.getPowerButtonDuration() <= CrossPointSettings::SHORT_PRESS_DURATION_MS) { // Fast path for short press // Needed because inputManager.isPressed() may take up to ~500ms to return the correct state return;