snark13/Xteink-X4-crosspoint-reader
1
0
Fork 0
mirror of https://github.com/daveallie/crosspoint-reader.git synced 2026-02-06 15:47:39 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: prevent OOM crash when loading large EPUBs (2000+ chapters)

Browse Source 
Remove the call to loadAllFileStatSlims() which pre-loads all ZIP central
directory entries into memory. For EPUBs with 2000+ chapters (like webnovels),
this exhausts the ESP32-C3's ~380KB RAM and causes abort().

The existing loadFileStatSlim() function already handles individual lookups
by scanning the central directory per-file when the cache is empty. This is
O(n*m) instead of O(n), but prevents memory exhaustion.

Fixes #134
This commit is contained in:
Daniel 2026-01-20 12:34:51 -08:00
parent 6d68466891
commit 5f34388143
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Epub/Epub/BookMetadataCache.cpp
View File

@ -133,17 +133,12 @@ bool BookMetadataCache::buildBookBin(const std::string& epubPath, const BookMeta
tocFile.close(); tocFile.close();
return false; return false;
} }
// TODO: For large ZIPs loading the all localHeaderOffsets will crash. // NOTE: We intentionally skip calling loadAllFileStatSlims() here.
// However not having them loaded is extremely slow. Need a better solution here. // For large EPUBs (2000+ chapters), pre-loading all ZIP central directory entries
// Perhaps only a cache of spine items or a better way to speedup lookups? // into memory causes OOM crashes on ESP32-C3's limited ~380KB RAM.
if (!zip.loadAllFileStatSlims()) { // Instead, we let loadFileStatSlim() do individual lookups per spine item.
Serial.printf("[%lu] [BMC] Could not load zip local header offsets for size calculations\n", millis()); // This is O(n*m) instead of O(n) for lookups, but avoids memory exhaustion.
bookFile.close(); // See: https://github.com/crosspoint-reader/crosspoint-reader/issues/134
spineFile.close();
tocFile.close();
zip.close();
return false;
}
uint32_t cumSize = 0; uint32_t cumSize = 0;
spineFile.seek(0); spineFile.seek(0);
int lastSpineTocIndex = -1; int lastSpineTocIndex = -1;