From 6cebde8a2debdf3149615e0739bac477f67cfab1 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 14 Jan 2026 22:30:30 +0000 Subject: [PATCH] Fix cppcheck warnings in free space probe - Cast uint64_t to unsigned long long for %llu format specifier (fixes type mismatch on platforms where uint64_t is unsigned long) - Add cppcheck-suppress for useStlAlgorithm on loop with side effects (preAllocate/truncate make std::find_if inappropriate here) --- src/activities/network/CalibreWirelessActivity.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/activities/network/CalibreWirelessActivity.cpp b/src/activities/network/CalibreWirelessActivity.cpp index 023cd27e..3b54d87d 100644 --- a/src/activities/network/CalibreWirelessActivity.cpp +++ b/src/activities/network/CalibreWirelessActivity.cpp @@ -112,7 +112,7 @@ void CalibreWirelessActivity::onExit() { // Now safe to turn off WiFi - no tasks using it Serial.printf("[%lu] [CAL] Disconnecting WiFi...\n", millis()); - WiFi.disconnect(false); // false = don't erase credentials, send disconnect frame + WiFi.disconnect(false); // false = don't erase credentials, send disconnect frame vTaskDelay(30 / portTICK_PERIOD_MS); // Allow disconnect frame to be sent Serial.printf("[%lu] [CAL] Setting WiFi mode OFF...\n", millis()); @@ -569,7 +569,7 @@ void CalibreWirelessActivity::handleGetDeviceInformation() { void CalibreWirelessActivity::handleFreeSpace() { const uint64_t freeBytes = getSDCardFreeSpace(); char response[64]; - snprintf(response, sizeof(response), "{\"free_space_on_device\":%llu}", freeBytes); + snprintf(response, sizeof(response), "{\"free_space_on_device\":%llu}", static_cast(freeBytes)); sendJsonResponse(OpCode::OK, response); } @@ -839,11 +839,13 @@ uint64_t CalibreWirelessActivity::getSDCardFreeSpace() const { uint64_t availableSpace = 64ULL * 1024 * 1024; // Minimum 64MB fallback for (const uint64_t size : probeSizes) { + // cppcheck-suppress useStlAlgorithm if (testFile.preAllocate(size)) { availableSpace = size; // Truncate back to 0 to release the allocation testFile.truncate(0); - Serial.printf("[%lu] [CAL] Free space probe: %llu bytes available\n", millis(), availableSpace); + Serial.printf("[%lu] [CAL] Free space probe: %llu bytes available\n", millis(), + static_cast(availableSpace)); break; } }