Refactor saving progress to dedicated function.

This commit is contained in:
Jonas Diemer 2026-01-19 22:46:45 +01:00
parent e6dd49dabe
commit 95b7f8008c
2 changed files with 22 additions and 26 deletions

View File

@ -182,30 +182,20 @@ void EpubReaderActivity::loop() {
} }
case EpubReaderMenuActivity::MenuAction::DELETE_CACHE: { case EpubReaderMenuActivity::MenuAction::DELETE_CACHE: {
xSemaphoreTake(renderingMutex, portMAX_DELAY); xSemaphoreTake(renderingMutex, portMAX_DELAY);
section.reset();
if (epub) { if (epub) {
// 2. BACKUP: Read current progress // 2. BACKUP: Read current progress
// We use the current variables that track our position // We use the current variables that track our position
uint16_t backupSpine = currentSpineIndex; uint16_t backupSpine = currentSpineIndex;
uint16_t backupPage = nextPageNumber; uint16_t backupPage = section->currentPage;
section.reset();
// 3. WIPE: Clear the cache directory // 3. WIPE: Clear the cache directory
epub->clearCache(); epub->clearCache();
// 4. RESTORE: Re-setup the directory and rewrite the progress file // 4. RESTORE: Re-setup the directory and rewrite the progress file
epub->setupCacheDir(); epub->setupCacheDir();
FsFile f; saveProgress(backupSpine, backupPage);
if (SdMan.openFileForWrite("ERS", epub->getCachePath() + "/progress.bin", f)) {
uint8_t data[4];
data[0] = backupSpine & 0xFF;
data[1] = (backupSpine >> 8) & 0xFF;
data[2] = backupPage & 0xFF;
data[3] = (backupPage >> 8) & 0xFF;
f.write(data, 4);
f.close();
Serial.println("[ERS] Progress restored after cache clear");
}
} }
exitActivity(); exitActivity();
updateRequired = true; updateRequired = true;
@ -440,19 +430,24 @@ void EpubReaderActivity::renderScreen() {
renderContents(std::move(p), orientedMarginTop, orientedMarginRight, orientedMarginBottom, orientedMarginLeft); renderContents(std::move(p), orientedMarginTop, orientedMarginRight, orientedMarginBottom, orientedMarginLeft);
Serial.printf("[%lu] [ERS] Rendered page in %dms\n", millis(), millis() - start); Serial.printf("[%lu] [ERS] Rendered page in %dms\n", millis(), millis() - start);
} }
saveProgress(currentSpineIndex, section->currentPage);
}
void EpubReaderActivity::saveProgress(int spineIndex, int page) {
FsFile f; FsFile f;
if (SdMan.openFileForWrite("ERS", epub->getCachePath() + "/progress.bin", f)) { if (SdMan.openFileForWrite("ERS", epub->getCachePath() + "/progress.bin", f)) {
uint8_t data[4]; uint8_t data[4];
data[0] = currentSpineIndex & 0xFF; data[0] = spineIndex & 0xFF;
data[1] = (currentSpineIndex >> 8) & 0xFF; data[1] = (spineIndex >> 8) & 0xFF;
data[2] = section->currentPage & 0xFF; data[2] = page & 0xFF;
data[3] = (section->currentPage >> 8) & 0xFF; data[3] = (page >> 8) & 0xFF;
f.write(data, 4); f.write(data, 4);
f.close(); f.close();
Serial.printf("[ERS] Progress saved: Chapter %d, Page %d\n", spineIndex, page);
} else {
Serial.printf("[ERS] Could not save progress!\n");
} }
} }
void EpubReaderActivity::renderContents(std::unique_ptr<Page> page, const int orientedMarginTop, void EpubReaderActivity::renderContents(std::unique_ptr<Page> page, const int orientedMarginTop,
const int orientedMarginRight, const int orientedMarginBottom, const int orientedMarginRight, const int orientedMarginBottom,
const int orientedMarginLeft) { const int orientedMarginLeft) {

View File

@ -25,6 +25,7 @@ class EpubReaderActivity final : public ActivityWithSubactivity {
void renderContents(std::unique_ptr<Page> page, int orientedMarginTop, int orientedMarginRight, void renderContents(std::unique_ptr<Page> page, int orientedMarginTop, int orientedMarginRight,
int orientedMarginBottom, int orientedMarginLeft); int orientedMarginBottom, int orientedMarginLeft);
void renderStatusBar(int orientedMarginRight, int orientedMarginBottom, int orientedMarginLeft) const; void renderStatusBar(int orientedMarginRight, int orientedMarginBottom, int orientedMarginLeft) const;
void saveProgress(int spineIndex, int page);
public: public:
explicit EpubReaderActivity(GfxRenderer& renderer, MappedInputManager& mappedInput, std::unique_ptr<Epub> epub, explicit EpubReaderActivity(GfxRenderer& renderer, MappedInputManager& mappedInput, std::unique_ptr<Epub> epub,