From a6344210376acf954df9140d76947ce488660539 Mon Sep 17 00:00:00 2001
From: Katie Paxton-Fear <36405442+InsiderPhD@users.noreply.github.com>
Date: Tue, 13 Jan 2026 13:46:34 +0000
Subject: [PATCH] Update SettingsActivity.cpp

just fixing the CI build failure
---
 src/activities/settings/SettingsActivity.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/activities/settings/SettingsActivity.cpp b/src/activities/settings/SettingsActivity.cpp
index 813b6f81..4e333b32 100644
--- a/src/activities/settings/SettingsActivity.cpp
+++ b/src/activities/settings/SettingsActivity.cpp
@@ -3,6 +3,7 @@
 #include <GfxRenderer.h>
 #include <HardwareSerial.h>
 
+#include <algorithm>
 #include <cstring>
 
 #include "CalibreSettingsActivity.h"
@@ -16,12 +17,11 @@
 namespace {
 const std::vector<SettingInfo>& getSettings() {
   static std::vector<SettingInfo> filteredSettings = []() {
+    const auto& allSettings = getSettingsList();
     std::vector<SettingInfo> filtered;
-    for (const auto& setting : getSettingsList()) {
-      if (!setting.hideFromDeviceUI) {
-        filtered.push_back(setting);
-      }
-    }
+    filtered.reserve(allSettings.size());
+    std::copy_if(allSettings.begin(), allSettings.end(), std::back_inserter(filtered),
+                 [](const SettingInfo& setting) { return !setting.hideFromDeviceUI; });
     return filtered;
   }();
   return filteredSettings;