From aa2e6ad0b352240eff6a8a3de1928c56da76b81a Mon Sep 17 00:00:00 2001 From: Arthur Tazhitdinov Date: Mon, 26 Jan 2026 14:26:38 +0500 Subject: [PATCH] refactor: Move MIN_SIZE_FOR_PROGRESS constant to the correct location and remove unused include --- lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp | 5 ++++- lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp index e93b3a72..1d7e2ab3 100644 --- a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp +++ b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp @@ -10,6 +10,9 @@ const char* HEADER_TAGS[] = {"h1", "h2", "h3", "h4", "h5", "h6"}; constexpr int NUM_HEADER_TAGS = sizeof(HEADER_TAGS) / sizeof(HEADER_TAGS[0]); +// Minimum file size (in bytes) to show progress bar - smaller chapters don't benefit from it +constexpr size_t MIN_SIZE_FOR_PROGRESS = 50 * 1024; // 50KB + const char* BLOCK_TAGS[] = {"p", "li", "div", "br", "blockquote"}; constexpr int NUM_BLOCK_TAGS = sizeof(BLOCK_TAGS) / sizeof(BLOCK_TAGS[0]); @@ -302,7 +305,7 @@ bool ChapterHtmlSlimParser::parseAndBuildPages() { // Update progress (call every 10% change to avoid too frequent updates) // Only show progress for larger chapters where rendering overhead is worth it bytesRead += len; - if (progressFn && totalSize >= ChapterHtmlSlimParser::MIN_SIZE_FOR_PROGRESS) { + if (progressFn && totalSize >= MIN_SIZE_FOR_PROGRESS) { const int progress = static_cast((bytesRead * 100) / totalSize); if (lastProgress / 10 != progress / 10) { lastProgress = progress; diff --git a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h index 456b19f8..afdf86d3 100644 --- a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h +++ b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h @@ -3,7 +3,6 @@ #include #include -#include #include #include