diff --git a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp
index 0ba165fe..79e6e6c7 100644
--- a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp
+++ b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp
@@ -40,6 +40,23 @@ bool matches(const char* tag_name, const char* possible_tags[], const int possib
return false;
}
+EpdFontFamily::Style getFontStyle(const int boldUntilDepth, const int italicUntilDepth, const int depth) {
+ if (boldUntilDepth < depth && italicUntilDepth < depth) {
+ return EpdFontFamily::BOLD_ITALIC;
+ } else if (boldUntilDepth < depth) {
+ return EpdFontFamily::BOLD;
+ } else if (italicUntilDepth < depth) {
+ return EpdFontFamily::ITALIC;
+ }
+ return EpdFontFamily::REGULAR;
+}
+
+void ChapterHtmlSlimParser::flushPartWordBuffer(const EpdFontFamily::Style fontStyle) {
+ partWordBuffer[partWordBufferIndex] = '\0';
+ currentTextBlock->addWord(partWordBuffer, fontStyle);
+ partWordBufferIndex = 0;
+}
+
// start a new text block if needed
void ChapterHtmlSlimParser::startNewTextBlock(const TextBlock::Style style) {
if (currentTextBlock) {
@@ -126,19 +143,8 @@ void XMLCALL ChapterHtmlSlimParser::startElement(void* userData, const XML_Char*
} else if (matches(name, BLOCK_TAGS, NUM_BLOCK_TAGS)) {
if (strcmp(name, "br") == 0) {
// flush word preceding
to currentTextBlock before calling startNewTextBlock
- EpdFontFamily::Style fontStyle = EpdFontFamily::REGULAR;
- if (self->boldUntilDepth < self->depth && self->italicUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::BOLD_ITALIC;
- } else if (self->boldUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::BOLD;
- } else if (self->italicUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::ITALIC;
- }
-
- self->partWordBuffer[self->partWordBufferIndex] = '\0';
- self->currentTextBlock->addWord(self->partWordBuffer, fontStyle);
- self->partWordBufferIndex = 0;
-
+ EpdFontFamily::Style fontStyle = getFontStyle(self->boldUntilDepth, self->italicUntilDepth, self->depth);
+ self->flushPartWordBuffer(fontStyle);
self->startNewTextBlock(self->currentTextBlock->getStyle());
} else {
self->startNewTextBlock((TextBlock::Style)self->paragraphAlignment);
@@ -163,22 +169,13 @@ void XMLCALL ChapterHtmlSlimParser::characterData(void* userData, const XML_Char
return;
}
- EpdFontFamily::Style fontStyle = EpdFontFamily::REGULAR;
- if (self->boldUntilDepth < self->depth && self->italicUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::BOLD_ITALIC;
- } else if (self->boldUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::BOLD;
- } else if (self->italicUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::ITALIC;
- }
+ EpdFontFamily::Style fontStyle = getFontStyle(self->boldUntilDepth, self->italicUntilDepth, self->depth);
for (int i = 0; i < len; i++) {
if (isWhitespace(s[i])) {
// Currently looking at whitespace, if there's anything in the partWordBuffer, flush it
if (self->partWordBufferIndex > 0) {
- self->partWordBuffer[self->partWordBufferIndex] = '\0';
- self->currentTextBlock->addWord(self->partWordBuffer, fontStyle);
- self->partWordBufferIndex = 0;
+ self->flushPartWordBuffer(fontStyle);
}
// Skip the whitespace char
continue;
@@ -200,9 +197,7 @@ void XMLCALL ChapterHtmlSlimParser::characterData(void* userData, const XML_Char
// If we're about to run out of space, then cut the word off and start a new one
if (self->partWordBufferIndex >= MAX_WORD_SIZE) {
- self->partWordBuffer[self->partWordBufferIndex] = '\0';
- self->currentTextBlock->addWord(self->partWordBuffer, fontStyle);
- self->partWordBufferIndex = 0;
+ self->flushPartWordBuffer(fontStyle);
}
self->partWordBuffer[self->partWordBufferIndex++] = s[i];
@@ -233,18 +228,9 @@ void XMLCALL ChapterHtmlSlimParser::endElement(void* userData, const XML_Char* n
matches(name, BOLD_TAGS, NUM_BOLD_TAGS) || matches(name, ITALIC_TAGS, NUM_ITALIC_TAGS) || self->depth == 1;
if (shouldBreakText) {
- EpdFontFamily::Style fontStyle = EpdFontFamily::REGULAR;
- if (self->boldUntilDepth < self->depth && self->italicUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::BOLD_ITALIC;
- } else if (self->boldUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::BOLD;
- } else if (self->italicUntilDepth < self->depth) {
- fontStyle = EpdFontFamily::ITALIC;
- }
+ EpdFontFamily::Style fontStyle = getFontStyle(self->boldUntilDepth, self->italicUntilDepth, self->depth);
- self->partWordBuffer[self->partWordBufferIndex] = '\0';
- self->currentTextBlock->addWord(self->partWordBuffer, fontStyle);
- self->partWordBufferIndex = 0;
+ self->flushPartWordBuffer(fontStyle);
}
}
diff --git a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h
index 5355211a..d0dc235f 100644
--- a/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h
+++ b/lib/Epub/Epub/parsers/ChapterHtmlSlimParser.h
@@ -39,6 +39,7 @@ class ChapterHtmlSlimParser {
bool hyphenationEnabled;
void startNewTextBlock(TextBlock::Style style);
+ void flushPartWordBuffer(EpdFontFamily::Style fontStyle);
void makePages();
// XML callbacks
static void XMLCALL startElement(void* userData, const XML_Char* name, const XML_Char** atts);