snark13/Xteink-X4-crosspoint-reader
1
0
Fork 0
mirror of https://github.com/daveallie/crosspoint-reader.git synced 2026-02-04 22:57:50 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(cppcheck): more clang format fix

Browse Source
This commit is contained in:
Brackyt 2026-01-26 00:33:27 +01:00
parent fce43feea1
commit f559f408bb
3 changed files with 91 additions and 89 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/GfxRenderer/GfxRenderer.cpp
View File

@ -821,7 +821,8 @@ void GfxRenderer::drawBitmap1Bit(const Bitmap &bitmap, const int x, const int y,
free(rowBytes); free(rowBytes);
} }
void GfxRenderer::drawTransparentBitmap(const Bitmap& bitmap, const int x, const int y, const int w, const int h) const { void GfxRenderer::drawTransparentBitmap(const Bitmap& bitmap, const int x, const int y, const int w,
const int h) const {
// Similar to drawBitmap1Bit but strictly skips 1s (white) in the source 1-bit data // Similar to drawBitmap1Bit but strictly skips 1s (white) in the source 1-bit data
// The Bitmap reader returns 2-bit packed data where 0-2=Black and 3=White for 1-bit sources // The Bitmap reader returns 2-bit packed data where 0-2=Black and 3=White for 1-bit sources
@ -880,7 +881,7 @@ void GfxRenderer::drawTransparentBitmap(const Bitmap& bitmap, const int x, const
if (val < 3) { if (val < 3) {
for (int sy = startY; sy < endY; sy++) { for (int sy = startY; sy < endY; sy++) {
for (int sx = startX; sx < endX; sx++) { for (int sx = startX; sx < endX; sx++) {
drawPixel(sx, sy, true); // Black drawPixel(sx, sy, true); // Black
} }
} }
} }
@ -984,7 +985,7 @@ void GfxRenderer::drawRoundedBitmap(const Bitmap& bitmap, const int x, const int
if (renderMode == BW) { if (renderMode == BW) {
pixelBlack = (val < 2); pixelBlack = (val < 2);
} else if (renderMode == GRAYSCALE_MSB) { } else if (renderMode == GRAYSCALE_MSB) {
pixelBlack = (val < 3); // Draw all non-white as black for icons/covers pixelBlack = (val < 3); // Draw all non-white as black for icons/covers
} else if (renderMode == GRAYSCALE_LSB) { } else if (renderMode == GRAYSCALE_LSB) {
pixelBlack = (val == 0); pixelBlack = (val == 0);
} }

100
lib/ThemeEngine/include/BasicElements.h
View File

@ -262,67 +262,67 @@ class Label : public UIElement {
// Binary search for cut point // Binary search for cut point
int len = remaining.length(); int len = remaining.length();
int cut = len; int cut = len;
// Find split point // Find split point
// Optimistic start: approximate chars that fit // Optimistic start: approximate chars that fit
int avgCharWidth = renderer.getTextWidth(fontId, "a"); int avgCharWidth = renderer.getTextWidth(fontId, "a");
if (avgCharWidth < 1) avgCharWidth = 8; if (avgCharWidth < 1) avgCharWidth = 8;
int approxChars = absW / avgCharWidth; int approxChars = absW / avgCharWidth;
if (approxChars < 1) approxChars = 1; if (approxChars < 1) approxChars = 1;
if (approxChars >= len) approxChars = len - 1; if (approxChars >= len) approxChars = len - 1;
// Refine from approxChars // Refine from approxChars
int w = renderer.getTextWidth(fontId, remaining.substr(0, approxChars).c_str()); int w = renderer.getTextWidth(fontId, remaining.substr(0, approxChars).c_str());
if (w < absW) { if (w < absW) {
// Grow // Grow
for (int i = approxChars; i <= len; i++) { for (int i = approxChars; i <= len; i++) {
if (renderer.getTextWidth(fontId, remaining.substr(0, i).c_str()) > absW) { if (renderer.getTextWidth(fontId, remaining.substr(0, i).c_str()) > absW) {
cut = i - 1; cut = i - 1;
break; break;
} }
cut = i; cut = i;
} }
} else { } else {
// Shrink // Shrink
for (int i = approxChars; i > 0; i--) { for (int i = approxChars; i > 0; i--) {
if (renderer.getTextWidth(fontId, remaining.substr(0, i).c_str()) <= absW) { if (renderer.getTextWidth(fontId, remaining.substr(0, i).c_str()) <= absW) {
cut = i; cut = i;
break; break;
} }
} }
} }
// Find last space before cut // Find last space before cut
if (cut < (int)remaining.length()) { if (cut < (int)remaining.length()) {
int space = -1; int space = -1;
for (int i = cut; i > 0; i--) { for (int i = cut; i > 0; i--) {
if (remaining[i] == ' ') { if (remaining[i] == ' ') {
space = i; space = i;
break; break;
}
} }
if (space != -1) cut = space; }
if (space != -1) cut = space;
} }
std::string line = remaining.substr(0, cut); std::string line = remaining.substr(0, cut);
// If we're at the last allowed line but still have more text // If we're at the last allowed line but still have more text
if ((int)lines.size() == maxLines - 1 && cut < (int)remaining.length()) { if ((int)lines.size() == maxLines - 1 && cut < (int)remaining.length()) {
if (ellipsis) { if (ellipsis) {
line = renderer.truncatedText(fontId, remaining.c_str(), absW); line = renderer.truncatedText(fontId, remaining.c_str(), absW);
} }
lines.push_back(line); lines.push_back(line);
break; break;
} }
lines.push_back(line); lines.push_back(line);
// Advance // Advance
if (cut < (int)remaining.length()) { if (cut < (int)remaining.length()) {
// Skip the space if check // Skip the space if check
if (remaining[cut] == ' ') cut++; if (remaining[cut] == ' ') cut++;
remaining = remaining.substr(cut); remaining = remaining.substr(cut);
} else { } else {
remaining = ""; remaining = "";
} }
} }
} else { } else {
@ -332,29 +332,29 @@ class Label : public UIElement {
} }
lines.push_back(finalText); lines.push_back(finalText);
} }
// Draw lines // Draw lines
int totalTextHeight = lines.size() * lineHeight; int totalTextHeight = lines.size() * lineHeight;
int startY = absY; int startY = absY;
// Vertical centering // Vertical centering
if (absH > 0 && totalTextHeight < absH) { if (absH > 0 && totalTextHeight < absH) {
startY = absY + (absH - totalTextHeight) / 2; startY = absY + (absH - totalTextHeight) / 2;
} }
for (size_t i = 0; i < lines.size(); i++) { for (size_t i = 0; i < lines.size(); i++) {
int lineWidth = renderer.getTextWidth(fontId, lines[i].c_str()); int lineWidth = renderer.getTextWidth(fontId, lines[i].c_str());
int drawX = absX; int drawX = absX;
if (alignment == Alignment::Center && absW > 0) { if (alignment == Alignment::Center && absW > 0) {
drawX = absX + (absW - lineWidth) / 2; drawX = absX + (absW - lineWidth) / 2;
} else if (alignment == Alignment::Right && absW > 0) { } else if (alignment == Alignment::Right && absW > 0) {
drawX = absX + absW - lineWidth; drawX = absX + absW - lineWidth;
} }
renderer.drawText(fontId, drawX, startY + i * lineHeight, lines[i].c_str(), black); renderer.drawText(fontId, drawX, startY + i * lineHeight, lines[i].c_str(), black);
} }
markClean(); markClean();
} }
}; };

73
lib/ThemeEngine/src/BasicElements.cpp
View File

@ -1,10 +1,11 @@
#include "BasicElements.h" #include "BasicElements.h"
#include <GfxRenderer.h>
#include "Bitmap.h" #include "Bitmap.h"
#include "ListElement.h" #include "ListElement.h"
#include "ThemeManager.h" #include "ThemeManager.h"
#include "ThemeTypes.h" #include "ThemeTypes.h"
#include <GfxRenderer.h>
namespace ThemeEngine { namespace ThemeEngine {
@ -23,7 +24,7 @@ void BitmapElement::draw(const GfxRenderer& renderer, const ThemeContext& contex
// Resolve simplified or relative paths // Resolve simplified or relative paths
if (path.find('/') == std::string::npos || (path.length() > 0 && path[0] != '/')) { if (path.find('/') == std::string::npos || (path.length() > 0 && path[0] != '/')) {
path = ThemeManager::get().getAssetPath(path); path = ThemeManager::get().getAssetPath(path);
} }
// 1. Check if we have a cached 1-bit render // 1. Check if we have a cached 1-bit render
@ -47,46 +48,46 @@ void BitmapElement::draw(const GfxRenderer& renderer, const ThemeContext& contex
// 2. Try Streaming (Absolute paths, large images) // 2. Try Streaming (Absolute paths, large images)
if (path.length() > 0 && path[0] == '/') { if (path.length() > 0 && path[0] == '/') {
FsFile file; FsFile file;
if (SdMan.openFileForRead("HOME", path, file)) { if (SdMan.openFileForRead("HOME", path, file)) {
Bitmap bmp(file, true); // (file, dithering=true) Bitmap bmp(file, true); // (file, dithering=true)
if (bmp.parseHeaders() == BmpReaderError::Ok) { if (bmp.parseHeaders() == BmpReaderError::Ok) {
// Center logic // Center logic
int drawX = absX; int drawX = absX;
int drawY = absY; int drawY = absY;
if (bmp.getWidth() < absW) drawX += (absW - bmp.getWidth()) / 2; if (bmp.getWidth() < absW) drawX += (absW - bmp.getWidth()) / 2;
if (bmp.getHeight() < absH) drawY += (absH - bmp.getHeight()) / 2; if (bmp.getHeight() < absH) drawY += (absH - bmp.getHeight()) / 2;
if (borderRadius > 0) { if (borderRadius > 0) {
renderer.drawRoundedBitmap(bmp, drawX, drawY, absW, absH, borderRadius); renderer.drawRoundedBitmap(bmp, drawX, drawY, absW, absH, borderRadius);
} else { } else {
renderer.drawBitmap(bmp, drawX, drawY, absW, absH); renderer.drawBitmap(bmp, drawX, drawY, absW, absH);
} }
drawSuccess = true; drawSuccess = true;
}
file.close();
} }
file.close();
}
} }
// 3. Fallback to RAM Cache (Standard method) // 3. Fallback to RAM Cache (Standard method)
if (!drawSuccess) { if (!drawSuccess) {
const std::vector<uint8_t>* data = ThemeManager::get().getCachedAsset(path); const std::vector<uint8_t>* data = ThemeManager::get().getCachedAsset(path);
if (data && !data->empty()) { if (data && !data->empty()) {
Bitmap bmp(data->data(), data->size()); Bitmap bmp(data->data(), data->size());
if (bmp.parseHeaders() == BmpReaderError::Ok) { if (bmp.parseHeaders() == BmpReaderError::Ok) {
int drawX = absX; int drawX = absX;
int drawY = absY; int drawY = absY;
if (bmp.getWidth() < absW) drawX += (absW - bmp.getWidth()) / 2; if (bmp.getWidth() < absW) drawX += (absW - bmp.getWidth()) / 2;
if (bmp.getHeight() < absH) drawY += (absH - bmp.getHeight()) / 2; if (bmp.getHeight() < absH) drawY += (absH - bmp.getHeight()) / 2;
if (borderRadius > 0) { if (borderRadius > 0) {
renderer.drawRoundedBitmap(bmp, drawX, drawY, absW, absH, borderRadius); renderer.drawRoundedBitmap(bmp, drawX, drawY, absW, absH, borderRadius);
} else { } else {
renderer.drawBitmap(bmp, drawX, drawY, absW, absH); renderer.drawBitmap(bmp, drawX, drawY, absW, absH);
}
drawSuccess = true;
} }
} drawSuccess = true;
}
}
} }
// 4. Cache result if successful // 4. Cache result if successful